Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add aria-hidden to visually hidden batch action toolbar #7789

Merged
merged 3 commits into from
Feb 12, 2021
Merged

Add aria-hidden to visually hidden batch action toolbar #7789

merged 3 commits into from
Feb 12, 2021

Conversation

dakahn
Copy link
Contributor

@dakahn dakahn commented Feb 11, 2021 •
edited
Loading

Closes #7200

JAWS was reading a visually hidden data table batch actions bar on page read. This sets aria-hidden with a boolean checking if the bars is shown or hidden 🏄🏽

Changelog

  • adds aria-hidden boolean prop on TableBatchActions component

Testing / Reviewing

  • with JAWS running and the page focused press INSERT+DOWN ARROW and you shouldn't hear the batch action bar announced.
  • Click an option then with with JAWS running and the page focused press INSERT+DOWN ARROW and you should hear the batch action bar announced.

@dakahn dakahn requested a review from a team as a code owner February 11, 2021 23:54
@dakahn dakahn changed the title 7200 jaws batch action bar Add aria-hidden to visually hidden batch action toolbar Feb 11, 2021
@netlify
Copy link

netlify bot commented Feb 12, 2021 •
edited
Loading

Deploy preview for carbon-elements ready!

Built with commit 1ff463f

https://deploy-preview-7789--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Feb 12, 2021 •
edited
Loading

Deploy preview for carbon-components-react ready!

Built without sensitive environment variables with commit 1ff463f

https://deploy-preview-7789--carbon-components-react.netlify.app

tw15egan
tw15egan approved these changes Feb 12, 2021
View reviewed changes
Copy link
Collaborator

@tw15egan tw15egan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 ✅

@kodiakhq kodiakhq bot merged commit dbe33f4 into carbon-design-system:master Feb 12, 2021
This was referenced Mar 22, 2021
Closed
Closed
@mashenka123
Copy link

@tw15egan Just wonder when will this be in the latest Carbon version? This is still blocking Kubernetes https://github.ibm.com/alchemy-containers/armada-ui/issues/6079

@tw15egan
Copy link
Collaborator

tw15egan commented Apr 6, 2021

@mashenka123 This should be included in the latest and based on the merge date was likely included in 7.29.0 release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tw15egan tw15egan tw15egan approved these changes

@joshblack joshblack joshblack approved these changes

@tay1orjones tay1orjones Awaiting requested review from tay1orjones

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

JAWS reads batch action bar which is invisible
4 participants
@dakahn @mashenka123 @tw15egan @joshblack