-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(notification): support component tokens #7808
Merged
kodiakhq
merged 5 commits into
carbon-design-system:master
from
janhassel:notification-component-tokens
Feb 17, 2021
Merged
feat(notification): support component tokens #7808
kodiakhq
merged 5 commits into
carbon-design-system:master
from
janhassel:notification-component-tokens
Feb 17, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploy preview for carbon-elements ready! Built with commit 823ce50 |
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit 823ce50 https://deploy-preview-7808--carbon-components-react.netlify.app |
joshblack
approved these changes
Feb 16, 2021
tw15egan
approved these changes
Feb 17, 2021
This was referenced Feb 18, 2021
1 task
2 tasks
This was referenced Mar 29, 2021
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, the inline notification and toast notification components do not match the intended style (based on sketch kit) when used in dark themes (g90/g100) with
props.lowContrast
.This PR implements the component-token approach used for the tag component. When css custom properties are not used, this will correct the styling to match the specs. With css custom properties enabled, developers are required to manually emit the component tokens (as with the tag tokens). Example:
Changelog
New
notification/_tokens.scss
with component-specific tokens for low-contrast notificationsChanged
get-token-value
mixinRemoved
white
theme colorsTesting / Reviewing
In the deploy preview, enable low contrast variant in both inline and toast notification story and change theme to g90 or g100. Also, ensure styling on white/g10 has no regressions.