fix(modal): override base paragraph styles in modal content #8046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emyarod
force-pushed
the
8043-modal-body-content-token
branch
from
147786a to
4711794
Compare
|
Deploy preview for carbon-elements ready! Built with commit 147786a |
|
Deploy preview for carbon-components-react ready! Built with commit 147786a https://deploy-preview-8046--carbon-components-react.netlify.app |
|
Deploy preview for carbon-elements ready! Built with commit ef39f58 |
|
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit ef39f58 https://deploy-preview-8046--carbon-components-react.netlify.app |
joshblack
approved these changes
Mar 9, 2021
tw15egan
added
status: ready to merge 🎉
and removed
status: ready for review 👀
status: visual review 🔍
labels
87 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8043
This PR overrides the system wide text style rules on paragraphs only within modals (similar to existing overrides on other components e.g. accordion)
Testing / Reviewing
Confirm the text styles are correct in our modal storybook examples