fix(DataTable): return correct sort direction in sort action callback #8048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emyarod
force-pushed
the
4704-return-correct-sort-direction-in-datatable-sort-header
branch
from
6e0ebd8 to
a9aeec9
Compare
emyarod
changed the title
emyarod
changed the title
|
Deploy preview for carbon-elements ready! Built with commit 6e0ebd8 |
|
Deploy preview for carbon-components-react ready! Built with commit 6e0ebd8 https://deploy-preview-8048--carbon-components-react.netlify.app |
|
Deploy preview for carbon-elements ready! Built with commit 5adf99c |
|
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit 5adf99c https://deploy-preview-8048--carbon-components-react.netlify.app |
dakahn
approved these changes
Mar 10, 2021
tw15egan
added
status: ready to merge 🎉
and removed
status: one more review 👀
status: ready for review 👀
labels
emyarod
deleted the
4704-return-correct-sort-direction-in-datatable-sort-header
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4704
This PR returns the correct sort direction to the
handleSortBycallback function in the DataTable's built in state managerTesting / Reviewing
Confirm that the table sort parameters passed down to a user-provided
handleSortBycallback accurately reflects the sort state now