fix(colors): initialize color vars with default values #8440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshblack
approved these changes
Apr 16, 2021
|
Deploy preview for carbon-elements ready! Built with commit ba10900 |
|
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit ba10900 https://deploy-preview-8440--carbon-components-react.netlify.app |
emyarod
force-pushed
the
8069-sass-var-global
branch
from
95dea4f to
ca6b092
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8069
This PR initializes color vars in the root of the color mixins file and assigns them to their default values
Testing / Reviewing
Dart Sass deprecation warnings should no longer be emitted during the build process and colors should no longer receive the
!globalflag