-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sass): notification refactor inline toast #9004
fix(sass): notification refactor inline toast #9004
Conversation
was talking to @tw15egan and it seems some of the styles within the |
✔️ Deploy Preview for carbon-react-next ready! 🔨 Explore the source changes: 9595912 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/60dc91370563bb00077bdf74 😎 Browse the preview: https://deploy-preview-9004--carbon-react-next.netlify.app/iframe |
✔️ Deploy Preview for carbon-elements ready! 🔨 Explore the source changes: 9595912 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/60dc9137e5393a000741e361 😎 Browse the preview: https://deploy-preview-9004--carbon-elements.netlify.app |
✔️ Deploy Preview for carbon-components-react ready! 🔨 Explore the source changes: 9595912 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/60dc9137f1a5760007e84106 😎 Browse the preview: https://deploy-preview-9004--carbon-components-react.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few small tweaks but otherwise looking good
packages/carbon-react/src/components/Notification/Notification.stories.js
Outdated
Show resolved
Hide resolved
packages/carbon-react/src/components/Notification/Notification.stories.js
Outdated
Show resolved
Hide resolved
packages/styles/scss/components/notification/_inline-notification.scss
Outdated
Show resolved
Hide resolved
packages/styles/scss/components/notification/_toast-notification.scss
Outdated
Show resolved
Hide resolved
packages/styles/scss/components/notification/_toast-notification.scss
Outdated
Show resolved
Hide resolved
…on.scss Co-authored-by: TJ Egan <[email protected]>
…on.scss Co-authored-by: TJ Egan <[email protected]>
Ready for your review again - removed knobs and stripped out a lot of the unneeded props. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 ✅
Closes #8905
Notification: inline-notification & toast-notification
to SASS modulesTesting:
yarn test --watch packages/styles/scss/components/__tests__/inline-notification-test.js
yarn test --watch packages/styles/scss/components/__tests__/toast-notification-test.js
packages/carbon-react
runyarn storybook
to make sure none of the styles are broken fornotification