Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sass): notification refactor inline toast #9004

Merged
merged 13 commits into from
Jun 30, 2021
Merged

fix(sass): notification refactor inline toast #9004

merged 13 commits into from
Jun 30, 2021

Conversation

andreancardona
Copy link
Contributor

Closes #8905

  • Refactors Notification: inline-notification & toast-notification to SASS modules

Testing:

  • run yarn test --watch packages/styles/scss/components/__tests__/inline-notification-test.js
  • run yarn test --watch packages/styles/scss/components/__tests__/toast-notification-test.js
  • Make sure tests pass
  • cd packages/carbon-react run yarn storybook to make sure none of the styles are broken for notification

@andreancardona
Copy link
Contributor Author

@joshblack

was talking to @tw15egan and it seems some of the styles within the feature flag are broken - should we leave that as is for now since that won't be an issue for the v11 release?

@netlify
Copy link

netlify bot commented Jun 23, 2021

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: 9595912

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/60dc91370563bb00077bdf74

😎 Browse the preview: https://deploy-preview-9004--carbon-react-next.netlify.app/iframe

@netlify
Copy link

netlify bot commented Jun 23, 2021

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: 9595912

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/60dc9137e5393a000741e361

😎 Browse the preview: https://deploy-preview-9004--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Jun 23, 2021

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: 9595912

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/60dc9137f1a5760007e84106

😎 Browse the preview: https://deploy-preview-9004--carbon-components-react.netlify.app

@andreancardona andreancardona marked this pull request as ready for review June 24, 2021 17:15
Copy link
Collaborator

@tw15egan tw15egan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few small tweaks but otherwise looking good

@andreancardona andreancardona requested a review from tw15egan June 24, 2021 18:20
@andreancardona
Copy link
Contributor Author

Few small tweaks but otherwise looking good

Ready for your review again - removed knobs and stripped out a lot of the unneeded props. :)

Copy link
Collaborator

@tw15egan tw15egan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 ✅

@andreancardona andreancardona enabled auto-merge (squash) June 29, 2021 14:58
@andreancardona andreancardona merged commit 0ccb047 into carbon-design-system:main Jun 30, 2021
@jnm2377 jnm2377 mentioned this pull request Jul 6, 2021
48 tasks
@andreancardona andreancardona changed the title 8905 notification refactor inline toast fix(sass): notification refactor inline toast Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor Notification to use Sass modules
3 participants