Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ListBox): add combobox, dropdown, multiselect stories #9205

Merged
merged 8 commits into from
Jul 26, 2021
Merged

feat(ListBox): add combobox, dropdown, multiselect stories #9205

merged 8 commits into from
Jul 26, 2021

Conversation

tw15egan
Copy link
Collaborator

@tw15egan tw15egan commented Jul 14, 2021 •
edited
Loading

Closes #9203

Adds in the following components to @carbon/styles and @carbon/react

  • Combobox
  • Dropdown
  • Listbox
  • Multiselect

Changelog

New

  • Styles, style tests, and stories for the above-listed components

Testing / Reviewing

Ensure the components listed above render as expected

@netlify
Copy link

netlify bot commented Jul 14, 2021 •
edited
Loading

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: ee7e74a

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/60fed1245be34800075e4cfd

😎 Browse the preview: https://deploy-preview-9205--carbon-react-next.netlify.app

@netlify
Copy link

netlify bot commented Jul 14, 2021 •
edited
Loading

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: ee7e74a

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/60fed1243cc0a900073af3ac

😎 Browse the preview: https://deploy-preview-9205--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Jul 14, 2021 •
edited
Loading

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: ee7e74a

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/60fed124e72de20007c4637e

😎 Browse the preview: https://deploy-preview-9205--carbon-components-react.netlify.app

@tw15egan
Copy link
Collaborator Author

MultiSelect is reliant on tag styles, so will need to wait until #9131 is merged in 👍

@tw15egan tw15egan force-pushed the list-box-sass-module branch 2 times, most recently from 5429409 to 2085d61 Compare July 20, 2021 14:51
@tw15egan tw15egan force-pushed the list-box-sass-module branch from 8387eac to 08a2017 Compare July 23, 2021 15:33
@tw15egan tw15egan marked this pull request as ready for review July 23, 2021 15:33
@tw15egan tw15egan requested a review from a team as a code owner July 23, 2021 15:33
@tw15egan tw15egan requested review from emyarod and sstrubberg July 23, 2021 15:33
emyarod
emyarod approved these changes Jul 23, 2021
View reviewed changes
Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@sstrubberg sstrubberg enabled auto-merge (squash) July 26, 2021 14:35
@sstrubberg sstrubberg merged commit 89d45b8 into carbon-design-system:main Jul 26, 2021
This was referenced Aug 3, 2021
Merged
Merged
@tw15egan tw15egan deleted the list-box-sass-module branch March 3, 2022 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emyarod emyarod emyarod approved these changes

@sstrubberg sstrubberg sstrubberg approved these changes

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor Listbox and associated components to use Sass Modules
4 participants
@tw15egan @emyarod @sstrubberg @andreancardona