Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(Styles): add styles public api tests #9231

Merged
merged 8 commits into from
Aug 3, 2021
Merged

test(Styles): add styles public api tests #9231

merged 8 commits into from
Aug 3, 2021

Conversation

tw15egan
Copy link
Collaborator

@tw15egan tw15egan commented Jul 20, 2021 •
edited
Loading

Closes #9168

Adds in tests for the @carbon/styles package Public API. Some tests already exist in packages/styles/scss/__tests__. This will exist in packages/styles/__tests__

Changelog

New

  • Snapshot test of all entry points
  • config tests
  • Ensures all entry points can be imported

Testing / Reviewing

Ensure all tests pass

@netlify
Copy link

netlify bot commented Jul 20, 2021 •
edited
Loading

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: 67414f6

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/610951a726126200080e2800

😎 Browse the preview: https://deploy-preview-9231--carbon-react-next.netlify.app

@tw15egan
Copy link
Collaborator Author

cc @joshblack

@netlify
Copy link

netlify bot commented Jul 20, 2021 •
edited
Loading

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: 67414f6

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/610951a7036a290008a68db7

😎 Browse the preview: https://deploy-preview-9231--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Jul 20, 2021 •
edited
Loading

✔️ Deploy Preview for carbon-components-react ready!

🔨 Explore the source changes: 67414f6

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/610951a724b5e70007701b62

😎 Browse the preview: https://deploy-preview-9231--carbon-components-react.netlify.app

@joshblack
Copy link
Contributor

Looking great 🔥

@tw15egan tw15egan force-pushed the styles-public-api-test branch from 289e681 to 8627624 Compare July 23, 2021 15:45
@tw15egan tw15egan marked this pull request as ready for review July 29, 2021 23:53
@tw15egan tw15egan requested a review from a team as a code owner July 29, 2021 23:53
@tw15egan tw15egan requested review from sstrubberg and jnm2377 July 29, 2021 23:53
@tw15egan tw15egan force-pushed the styles-public-api-test branch from 8627624 to 478db50 Compare July 30, 2021 14:26
sstrubberg
sstrubberg approved these changes Jul 30, 2021
View reviewed changes
Copy link
Member

@sstrubberg sstrubberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

🔥

@kodiakhq
Copy link
Contributor

kodiakhq bot commented Aug 2, 2021

This PR currently has a merge conflict. Please resolve this and then re-add the status: ready to merge 🎉 label.

@jnm2377
Copy link
Contributor

jnm2377 commented Aug 2, 2021

@tw15egan sorry it took me so long to review, looks like it'll be good to merge once the merge conflict is resolved!

@tw15egan tw15egan force-pushed the styles-public-api-test branch from c0af6b9 to b5dce98 Compare August 3, 2021 13:27
@kodiakhq kodiakhq bot merged commit e31d293 into carbon-design-system:main Aug 3, 2021
This was referenced Aug 3, 2021
Merged
Merged
@tw15egan tw15egan deleted the styles-public-api-test branch March 3, 2022 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sstrubberg sstrubberg sstrubberg approved these changes

@jnm2377 jnm2377 jnm2377 approved these changes

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Write Public API test for @carbon/styles for package exports
4 participants
@tw15egan @joshblack @jnm2377 @sstrubberg