Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Carbon-React): add prefix hook refactor Loading -> UnorderedList #9689

Merged
merged 4 commits into from
Sep 21, 2021
Merged

feat(Carbon-React): add prefix hook refactor Loading -> UnorderedList #9689

merged 4 commits into from
Sep 21, 2021

Conversation

dakahn
Copy link
Contributor

@dakahn dakahn commented Sep 17, 2021 •
edited
Loading

ref #9687

Refactors prefix to use context for components Loading thru UnorderedList 🏄🏾

Testing / Reviewing

Test that the components function and have classname prefixes as expected in the corresponding storybooks

@dakahn dakahn requested a review from a team as a code owner September 17, 2021 00:32
@dakahn dakahn requested review from joshblack and jnm2377 September 17, 2021 00:32
@netlify
Copy link

netlify bot commented Sep 17, 2021 •
edited
Loading

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: e62bd1a

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/614a0ba456b00e00073a9821

😎 Browse the preview: https://deploy-preview-9689--carbon-react-next.netlify.app

@netlify
Copy link

netlify bot commented Sep 17, 2021 •
edited
Loading

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: e62bd1a

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/614a0ba4f7fcf100071c72fa

😎 Browse the preview: https://deploy-preview-9689--carbon-components-react.netlify.app

@netlify
Copy link

netlify bot commented Sep 17, 2021 •
edited
Loading

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: e62bd1a

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/614a0ba4f04edf0008860880

😎 Browse the preview: https://deploy-preview-9689--carbon-elements.netlify.app

@jnm2377
Copy link
Contributor

jnm2377 commented Sep 17, 2021

Ah, looks like tests are failing bc One of the commands failed: Error: Cannot find module '../../internal/usePrefix', which is being added in this PR: #9687

So I think this is blocked until that one is merged.

@kodiakhq kodiakhq bot merged commit 58b5202 into carbon-design-system:main Sep 21, 2021
@joshblack joshblack mentioned this pull request Sep 22, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnm2377 jnm2377 jnm2377 approved these changes

@joshblack joshblack joshblack approved these changes

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dakahn @jnm2377 @joshblack