-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(react): add unstable_Stack component #9876
feat(react): add unstable_Stack component #9876
Conversation
✔️ Deploy Preview for carbon-react-next ready! 🔨 Explore the source changes: 9af6c40 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/617730e5c117980007cdfb79 😎 Browse the preview: https://deploy-preview-9876--carbon-react-next.netlify.app |
Question for you @tay1orjones, my code had |
✔️ Deploy Preview for carbon-components-react ready! 🔨 Explore the source changes: 9af6c40 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/617730e64159820008260c29 😎 Browse the preview: https://deploy-preview-9876--carbon-components-react.netlify.app/ |
✔️ Deploy Preview for carbon-elements ready! 🔨 Explore the source changes: 9af6c40 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/617730e5b6b7ea000760f4b0 😎 Browse the preview: https://deploy-preview-9876--carbon-elements.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm super into this implementation! I think the usage of grid gap is a fantastic idea.
I'm happy to knock out some tests for it once any other feedback is incorporated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Newest changes feel great! 🔥 Consolidating down to just gap
and also very much in support of the VStack
and HStack
exports
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
Closes #9821
This PR adds in a
Stack
component to be used for vertical spacing along with other components in the design system. This is a useful utility in a component-based model when margin is no longer used by components.By default, the
Stack
uses agap
prop where you can provide a number or a string. If it's a number, it will map to our spacing scale. If it's a string, it will be a custom value and requires a unit.Changelog
New
Changed
carbon-react
Removed
Testing / Reviewing