-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
style(DatePicker): updated tokens #9951
style(DatePicker): updated tokens #9951
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me know what you think about these suggestions. I'm not sure when a brand
token wins out against button
if the element is effectively a button.
✔️ Deploy Preview for carbon-react-next ready! 🔨 Explore the source changes: 2e30a27 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/6179789d1d3722000835d67c 😎 Browse the preview: https://deploy-preview-9951--carbon-react-next.netlify.app |
✔️ Deploy Preview for carbon-elements ready! 🔨 Explore the source changes: 2e30a27 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/6179789d569d2f00074a91e2 😎 Browse the preview: https://deploy-preview-9951--carbon-elements.netlify.app |
✔️ Deploy Preview for carbon-components-react ready! 🔨 Explore the source changes: 2e30a27 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/6179789dad17f8000814d57a 😎 Browse the preview: https://deploy-preview-9951--carbon-components-react.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just have some questions around some of the tokens. Maybe we need design review on this for the tokens?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good once @jnm2377's feedback above is addressed 👍
REF #9888
Update tokens to v11 based on the following specs.
Updated the following:
ui-01
->layer-01
text-01
->text-primary
hover-ui
->background-hover
ui-05
->border-inverse
disabled-02
->text-disabled
icon-01
->icon-primary
interactive-01
->button-primary
interactive-04
->border-interactive
text-05
->text-helper
link-01
->link-primary
text-04
->text-on-color
ui-02
->layer-02