Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(DatePicker): updated tokens #9951

Merged

Conversation

sstrubberg
Copy link
Member

@sstrubberg sstrubberg commented Oct 26, 2021

REF #9888

Update tokens to v11 based on the following specs.

  • Replaced compat theme with theme.
  • Brought in button tokens.

Updated the following:

  • ui-01 -> layer-01
  • text-01 -> text-primary
  • hover-ui -> background-hover
  • ui-05 -> border-inverse
  • disabled-02 -> text-disabled
  • icon-01 -> icon-primary
  • interactive-01 -> button-primary
  • interactive-04 -> border-interactive
  • text-05 -> text-helper
  • link-01 -> link-primary
  • text-04 -> text-on-color
  • ui-02 -> layer-02

@sstrubberg sstrubberg requested a review from a team as a code owner October 26, 2021 16:43
Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me know what you think about these suggestions. I'm not sure when a brand token wins out against button if the element is effectively a button.

@netlify
Copy link

netlify bot commented Oct 26, 2021

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: 2e30a27

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/6179789d1d3722000835d67c

😎 Browse the preview: https://deploy-preview-9951--carbon-react-next.netlify.app

@netlify
Copy link

netlify bot commented Oct 26, 2021

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: 2e30a27

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/6179789d569d2f00074a91e2

😎 Browse the preview: https://deploy-preview-9951--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Oct 26, 2021

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: 2e30a27

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/6179789dad17f8000814d57a

😎 Browse the preview: https://deploy-preview-9951--carbon-components-react.netlify.app

@sstrubberg sstrubberg requested a review from abbeyhrt October 26, 2021 21:09
Copy link
Contributor

@jnm2377 jnm2377 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just have some questions around some of the tokens. Maybe we need design review on this for the tokens?

Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good once @jnm2377's feedback above is addressed 👍

@sstrubberg sstrubberg requested a review from jnm2377 October 27, 2021 15:49
@sstrubberg sstrubberg enabled auto-merge (squash) October 27, 2021 16:04
@sstrubberg sstrubberg merged commit 5fcfc31 into carbon-design-system:main Oct 27, 2021
@sstrubberg sstrubberg deleted the style/datepicker-tokens branch October 27, 2021 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants