-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
style(structured-list): update theme import #9970
style(structured-list): update theme import #9970
Conversation
FYI @sstrubberg |
✔️ Deploy Preview for carbon-react-next ready! 🔨 Explore the source changes: 767aa7b 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/61804685f270ca00072a3cd0 😎 Browse the preview: https://deploy-preview-9970--carbon-react-next.netlify.app |
✔️ Deploy Preview for carbon-components-react ready! 🔨 Explore the source changes: 767aa7b 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/6180468534bb800009e503f0 😎 Browse the preview: https://deploy-preview-9970--carbon-components-react.netlify.app |
✔️ Deploy Preview for carbon-elements ready! 🔨 Explore the source changes: 767aa7b 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/618046855ea22c0007b68d70 😎 Browse the preview: https://deploy-preview-9970--carbon-elements.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like there are some tokens still being used from compat/theme
potentially like $hover-row
that need to be replaced 👀
…ithub.com/motou/carbon into style/change-structured-list-color-tokens
@joshblack it seems that |
Yeah of course @motou! cc @aagonzales is the change to the docs the correct substitution for |
Thanks for adding! This would actually be a split one. It could be |
@motou can you update to the base branch. i appear to be unable to. |
…ithub.com/motou/carbon into style/change-structured-list-color-tokens
@aagonzales sure, the token doc is updated. |
@motou Can you enable this? |
REF #9888
Update color tokens to v11 based on the following specs: https://github.com/carbon-design-system/carbon/blob/main/docs/migration/11.x-color.md