Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(structured-list): update theme import #9970

Merged
merged 8 commits into from
Nov 1, 2021
Merged

style(structured-list): update theme import #9970

merged 8 commits into from
Nov 1, 2021

Conversation

motou
Copy link
Contributor

@motou motou commented Oct 27, 2021

REF #9888

Update color tokens to v11 based on the following specs: https://github.com/carbon-design-system/carbon/blob/main/docs/migration/11.x-color.md

  • Replaced compat theme with theme.

@motou motou requested a review from a team as a code owner October 27, 2021 19:12
@motou
Copy link
Contributor Author

motou commented Oct 27, 2021

FYI @sstrubberg

@netlify
Copy link

netlify bot commented Oct 27, 2021

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: 767aa7b

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/61804685f270ca00072a3cd0

😎 Browse the preview: https://deploy-preview-9970--carbon-react-next.netlify.app

@netlify
Copy link

netlify bot commented Oct 27, 2021

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: 767aa7b

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/6180468534bb800009e503f0

😎 Browse the preview: https://deploy-preview-9970--carbon-components-react.netlify.app

@netlify
Copy link

netlify bot commented Oct 27, 2021

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: 767aa7b

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/618046855ea22c0007b68d70

😎 Browse the preview: https://deploy-preview-9970--carbon-elements.netlify.app

Copy link
Contributor

@joshblack joshblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like there are some tokens still being used from compat/theme potentially like $hover-row that need to be replaced 👀

@motou
Copy link
Contributor Author

motou commented Oct 28, 2021

$hover-row

@joshblack it seems that $hover-row is not defined in the doc. So I add it in the docs/migration/11.x-color.md and change it to $background-hover. Is that okay?

@sstrubberg sstrubberg requested a review from joshblack October 29, 2021 14:21
@joshblack
Copy link
Contributor

Yeah of course @motou!

cc @aagonzales is the change to the docs the correct substitution for $hover-row? 👀

@aagonzales
Copy link
Member

Thanks for adding! This would actually be a split one. It could be $background-hover or $layer-hover-01 in v11.

@sstrubberg
Copy link
Member

@motou can you update to the base branch. i appear to be unable to.

@motou
Copy link
Contributor Author

motou commented Oct 29, 2021

@aagonzales sure, the token doc is updated.

@sstrubberg
Copy link
Member

@motou Can you enable this?

image

@sstrubberg sstrubberg merged commit fe9428a into carbon-design-system:main Nov 1, 2021
@motou motou deleted the style/change-structured-list-color-tokens branch November 2, 2021 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants