Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generics details 9: forward declarations #1084

Merged
merged 57 commits into from
Apr 13, 2022
Merged

Generics details 9: forward declarations #1084

merged 57 commits into from
Apr 13, 2022

Conversation

josh11b
Copy link
Contributor

@josh11b josh11b commented Feb 11, 2022 •
edited
Loading

Allow interfaces and implementations to be forward declared.

// Forward declare interface `F`
interface F;
class C {
  // Forward declare `C` implements `F`
  impl as F;
}
// Definitions corresponding to forward declarations
interface F { ... }
impl C as F { ... }

To allow members of interfaces with default definitions to be forward declared, prefix them with the keyword default, following #1082 .

@josh11b josh11b added the proposal A proposal label Feb 11, 2022
@josh11b josh11b requested a review from a team February 11, 2022 21:52
josh11b added 21 commits February 11, 2022 13:52
@josh11b
Filling out template with PR 1084
986b7e8
@josh11b
Rough draft with the main points to make
821e99a
@josh11b
Update examples
881a329
@josh11b
Mark defaults with default so they may be declared separately
3107b8c
@josh11b
Out-of-line definition of final members
26ccbc7
@josh11b
Impls definitions for incomplete types
b6641e1
@josh11b
Work on proposal text
ff75bfa
@josh11b
Finish first pass of design
ff823d5
@josh11b
Polish examples
e6e7c32
@josh11b
Fix up alternatives
a198167
@josh11b
Filling out template with PR 1084
7f4d803
@josh11b
Rough draft with the main points to make
90aa390
@josh11b
Update examples
36f1de5
@josh11b
Mark defaults with default so they may be declared separately
3adddb4
@josh11b
Out-of-line definition of final members
a588241
@josh11b
Impls definitions for incomplete types
029faa7
@josh11b
Work on proposal text
a57e37e
@josh11b
Finish first pass of design
451bfb5
@josh11b
Polish examples
91ed3e5
@josh11b
Fix up alternatives
2890173
@josh11b
Merge branch 'forward' of github.com:josh11b/carbon-lang into forward
f5d840a
@josh11b josh11b marked this pull request as ready for review February 16, 2022 00:40
@josh11b josh11b requested a review from a team as a code owner February 16, 2022 00:40
@josh11b josh11b requested a review from zygoloid February 16, 2022 00:40
@github-actions github-actions bot added the proposal rfc Proposal with request-for-comment sent out label Feb 16, 2022
zygoloid
zygoloid reviewed Apr 7, 2022
View reviewed changes
docs/design/generics/details.md Outdated Show resolved Hide resolved
docs/design/generics/details.md Show resolved Hide resolved
docs/design/generics/details.md Outdated Show resolved Hide resolved
docs/design/generics/details.md Outdated Show resolved Hide resolved
docs/design/generics/details.md Outdated Show resolved Hide resolved
docs/design/generics/details.md Outdated Show resolved Hide resolved
docs/design/generics/details.md Outdated Show resolved Hide resolved
docs/design/generics/details.md Outdated Show resolved Hide resolved
docs/design/generics/details.md Outdated Show resolved Hide resolved
chandlerc
chandlerc reviewed Apr 9, 2022
View reviewed changes
Copy link
Contributor

@chandlerc chandlerc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't dig in significantly, but did an overview and wanted to say this looks really nicely captured here.

proposals/p1084.md Outdated Show resolved Hide resolved
@josh11b @chandlerc
Update proposals/p1084.md
0348ec3 
Co-authored-by: Chandler Carruth <[email protected]>
@zygoloid zygoloid merged commit 48fb3d5 into carbon-language:trunk Apr 13, 2022
@github-actions github-actions bot added proposal accepted Decision made, proposal accepted and removed proposal rfc Proposal with request-for-comment sent out labels Apr 13, 2022
@josh11b josh11b deleted the forward branch April 13, 2022 20:40
chandlerc added a commit that referenced this pull request Jun 28, 2022
@josh11b @zygoloid @chandlerc
Generics details 9: forward declarations (#1084)
06174c5 
Allow interfaces and implementations to be forward declared.

```
// Forward declare interface `F`
interface F;
class C {
  // Forward declare `C` implements `F`
  impl as F;
}
// Definitions corresponding to forward declarations
interface F { ... }
impl C as F { ... }
```

To allow members of interfaces with default definitions to be forward declared, prefix them with the keyword `default`, following #1082.

Co-authored-by: Richard Smith <[email protected]>
Co-authored-by: Chandler Carruth <[email protected]>
zygoloid added a commit to zygoloid/carbon-lang that referenced this pull request Sep 20, 2022
@zygoloid
Add more xrefs to carbon-language#2022 and to carbon-language#1084.
b12a666
@josh11b josh11b mentioned this pull request Dec 17, 2022
Open
@chandlerc chandlerc added the documentation An issue or proposed change to our documentation label Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chandlerc chandlerc chandlerc left review comments

@zygoloid zygoloid zygoloid approved these changes

Assignees
No one assigned
Labels
documentation An issue or proposed change to our documentation proposal accepted Decision made, proposal accepted proposal A proposal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@josh11b @zygoloid @chandlerc