Integrate description of tuple indexing into member access better. #3679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve design changes from #3646 to integrate better into the overall description of member access design.
zygoloid
changed the title
geoffromer
approved these changes
Feb 2, 2024
|
(Not merging in case you wanted a review from both of us) |
|
@chandlerc I think it'd be useful for a lead other than myself to confirm this isn't inadvertently changing the direction in some important way. |
chandlerc
approved these changes
Feb 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the exposition of the design changes from #3646 to integrate better into the overall description of member access design.
This fixes the incorrect description of the rules for
->by instead relying on the general rule that->is rewritten to use*and.before any other processing is done, and generally makes integer-literal names be less of a special case.