change tuple index #4218
Merged
change tuple index #4218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brymer-meneses
force-pushed
the
tuple-indexing-2
branch
from
41c5b56 to
d996d8e
Compare
jonmeow
approved these changes
Aug 15, 2024
|
Sorry, can you run autoupdate again? Looks like there's still some small difference in the lowering output, a line of code change (sometimes these take a couple autoupdate runs to get fixed, when autoupdate causes the line numbers to change) |
|
Sorry, about that. I think that should be resolved by now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the tuple index from tuple[0] to tuple.0 in accordance with the accepted propsal #3646
I messed up syncing to trunk on my original PR #4186, that's why I'm starting on a blank state. Please let me know if I missed incorporating a change from my prior PR.