[NFC] In DeclNameStack::AddName(), use NameScope::AddRequired() instead of duplicating its logic #4610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…duplicating its logic
danakj
reviewed
Dec 2, 2024
| name_context.unresolved_name_id, add_scope); | ||
| CARBON_CHECK( | ||
| result.is_inserted(), | ||
| "Duplicate names should have been resolved previously: {0} in {1}", |
There was a problem hiding this comment.
I was going to approve, but I see the diagnostic is changed.
The diagnostic on duplicate entry before:
"Duplicate names should have been resolved previously: {unresolved_name_id} in {parent_scope_id}"
The diagnostic on duplicate now:
"Failed to add required name: {unresolved_name_id}"
Maybe that's fine, or maybe we should pass in the parent scope id, not sure so I'll let someone else review.
There was a problem hiding this comment.
Note that this is a crash diagnostic, so not expected to occur unless there's a bug in the compiler logic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pure code deduplication change.