ImplWitness
#4679
Merged
ImplWitness
#4679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josh11b
force-pushed
the
witness
branch
2 times, most recently
from
32db121 to
a19c40f
Compare
zygoloid
approved these changes
Jan 2, 2025
zygoloid
reviewed
Jan 2, 2025
Co-authored-by: Richard Smith <[email protected]>
Merged
via the queue into
carbon-language:trunk
with commit Jan 2, 2025
c5fd8f4
7 of 8 checks passed
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 3, 2025
Imported declarations that are contained within a generic, such as an `impl forall...` would be given an abstract symbolic constant value instead of a concrete generic value in some cases where the function was used in an api file and impl file of the same library. This caused #4679 to fail using `ImplicitAs.Convert` transitively imported from the prelude. --------- Co-authored-by: Josh L <[email protected]> Co-authored-by: Richard Smith <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
InterfaceWitness->ImplWitnessSpecificIdin theImplWitness. This allows theInstBlockit contains to have its own identity, allowing it to be changed as the impl is processed. Evaluation only updates the specific.ImplWitnessat the start of the impl definition. In the future, this will be populated with the values of non-function associated constants. For now, it starts full of invalid instruction ids.Note that the non-SemIR testdata changes are to these file:
toolchain/check/testdata/impl/lookup/fail_todo_undefined_impl.carbontoolchain/check/testdata/struct/import.carbontoolchain/check/testdata/tuple/import.carbonThe last two are due to an import of generics bug exposed by this PR, which will be fixed in a follow-on.