Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suppress testing SemIR in int builtin tests. #4748
Suppress testing SemIR in int builtin tests. #4748
Changes from 5 commits
3ec37ac
b8ad5d3
dd2f702
5174ed9
38cb05b
ac32293
adc31c1
c1722c3
633476f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The SemIR seams still useful, and the only real test we have for the runtime call case. Would it make sense to split the runtime call tests out to files that continue to dump SemIR and only skip it in the ones where we do compile time validation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the only thing this is testing that's specific to each builtin is that a runtime call is valid. Beside that, the handling is not specific to the particular builtin -- we get the same call SemIR regardless of the kind of builtin -- so I think it's probably good enough to test that only once rather than once per builtin.
To that end, I've gone ahead and added SemIR output coverage for runtime calls to
toolchain/check/testdata/function/builtin/call.carbon
(which previously only covered compile-time calls).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure... Maybe
RuntimeCallIsValid
or something to make that a bit more obvious why there is nothing verified beyond that?