CIP4 - Wallet checksum #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SebastienGllmt
commented
May 9, 2020
|
|
||
| Although there is no specification for CRC32 and many variations exist, in Cardano we use the CRC-32-IEEE variation. You can find a C implementation [here](https://github.com/cardano-foundation/ledger-app-cardano/blob/3f784d23c1b87df73cda552ef01428d3e2733237/src/crc32.c#L6) | ||
|
|
||
| ### Hash algorithms used in Shelley mainnet |
There was a problem hiding this comment.
This part is mostly the part up for discussion. I'm open to any change for Shelley (since all users will get a new checksum anyway), or we can decide to keep it exactly the same if people want that
vsubhuman
approved these changes
May 10, 2020
crptmppt
approved these changes
Oct 20, 2020
KtorZ
approved these changes
Oct 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussion: https://forum.cardano.org/t/cip4-wallet-checksum/32819
This describes the wallet checksum that is implemented in the Yoroi Extension (and that will eventually be present in Yoroi Mobile). The goal of this CIP is to agree on the generation strategy for standardization with Daedalus in the future.