CIP-0068 | Extra field #458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KtorZ
reviewed
Feb 4, 2023
| @@ -115,9 +116,15 @@ metadata = | |||
| ? mediaType : bounded_bytes, ; UTF-8 | |||
| ? description : bounded_bytes, ; UTF-8 | |||
| ? files : [* files_details] | |||
| ; ... Additional properties are allowed | |||
There was a problem hiding this comment.
Not sure to follow this line 🤔 ? Is this in reference to the new extra ? In which case, additional properties aren't really on the metadata record, right?
There was a problem hiding this comment.
This comment is just to clarify that additional proprieties are allowed within the metadata field.
There was a problem hiding this comment.
@KtorZ it's not really related to the extra field. Just thought I sneak it into the PR, wanted to make it more explicit that additional properties are allowed.
Bad wording in my commit message...
KtorZ
approved these changes
Feb 8, 2023
rphair
approved these changes
Feb 8, 2023
rphair
added
the
Update
Ryun1
pushed a commit
to Ryun1/CIPs
that referenced
this pull request
Nov 17, 2023
* Added extra field; made it explicit extra fields are allowed * Added extra field to general definition * Added third field explanation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added extra field to datums to allow for user customized data. Additionally made it explicit that additional properties are alllowed in metadata.
@perturbing agrees on these changes as well.