-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CIP-0068 | Clarify label prefixes #471
Conversation
Thanks @mateusap1. This was indeed not very obvious. It wasn't clear back then how the labels will actually look like and then it was forgotten to specify them correctly in CIP-0068. However I think as a general convention and for convenience e.g. |
@alessandrokonrad Thanks for your quick reply.
I made a comment at the end of the "Labels" section trying to pass that idea. It reads as follows
Let me know if this satisfies your concern or if you still have any suggestions / issues. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks to me like the added text clarifies what was posted in comments so far, so I'd approve this as long as @alessandrokonrad you think it satisfies your latest comment & @SmaugPool and other interested parties have no objections.
@rphair yes this LGTM |
* added section clarifying labels * made wording less repetitive * add reference to CIP 67 * remove repeated references
By reading the CIP-0068 and trying to implement it myself I was convinced the asset name should literally be prefixed with the label
(100)
and not with the implementation suggested by CIP-0067, there was no reference whatsoever to the correct label convention as far as I am aware and this PR tries to make things more clear for future developers attempting to implement CIP-0068 on their own.