Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The chainfollower took multiple days to sync the assets. This wasn't practically since the time will likely increase in the future. Additionally it was needed to set the starting point of the chainfollower with two environment variables, which was just seen as a work around.
The problem were:
This hindered users to use the background easily without days of syncing.
Proposed Solution
We are saving assets in a local cache and save them batch wise. Additionally I adjusted the
insertAssets
function to skip already existing assets. Through this solution we are able to remove the checkhasAsset
for each asset (which takes a few seconds for every asset)Additionally catching errors from the Chainfollower and continuing the chainfollower.
This solution increases the speed on mainnet to 10% Assets per hour + removes the need of the custom starting point.