Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed module filtering example and add tests #50

Merged
merged 2 commits into from
Nov 4, 2022
Merged

fixed module filtering example and add tests #50

merged 2 commits into from
Nov 4, 2022

Conversation

cardoe
Copy link
Owner

@cardoe cardoe commented Nov 4, 2022

Fixed the module filtering example to actually work. Added extra tests going forward. fixes #27

@cardoe
extra tests around module handling
222e122 
added some tests around module handling to expose #27
@cardoe
fix example to allow for filtering
bd98d70 
Since we include all submodules for logging purposes, this example
couldn't ever work because it always includes "large_example" so no
filtering at "large_example::foo" would ever work. fixes #27
@cardoe cardoe merged commit 97fca9b into master Nov 4, 2022
@cardoe cardoe deleted the extra-testing branch November 4, 2022 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Module filtering does not work
1 participant
@cardoe