Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow builds from external contributors #728

Closed
2 tasks done
steve-todorov opened this issue Jul 9, 2023 · 0 comments · Fixed by #729
Closed
2 tasks done

Allow builds from external contributors #728

steve-todorov opened this issue Jul 9, 2023 · 0 comments · Fixed by #729
Assignees

Comments

@steve-todorov
Copy link
Collaborator

steve-todorov commented Jul 9, 2023

Task Description

There is no native way to safely allow builds for external contributors with the existing settings in Github.
It is possible to configure builds to require manual approval -- this does not pass the secrets to the forked repository, which in our case are necessary for the integration tests to run. This can be solved by using the pull_request_target event, but then it ignores any approval you might have configured and directly builds the PR which is obviously dangerous.

The only working "workaround" to this problem is to use Environments and configure the Required reviewers.
After a careful review of the PR the build can then be approved and it will be executed as expected.

Tasks

The following tasks will need to be carried out:

  • Implement the necessary pipeline changes.
  • Create the environment containing the necessary secrets for the integration tests and publishing the docs previews.

Task Relationships

This task:

  • Is a sub-task of: #
  • Depends on: #
  • Is a follow-up of: #
  • Relates to: #

Useful Links

Help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant