You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There is no native way to safely allow builds for external contributors with the existing settings in Github.
It is possible to configure builds to require manual approval -- this does not pass the secrets to the forked repository, which in our case are necessary for the integration tests to run. This can be solved by using the pull_request_target event, but then it ignores any approval you might have configured and directly builds the PR which is obviously dangerous.
The only working "workaround" to this problem is to use Environments and configure the Required reviewers.
After a careful review of the PR the build can then be approved and it will be executed as expected.
Tasks
The following tasks will need to be carried out:
Implement the necessary pipeline changes.
Create the environment containing the necessary secrets for the integration tests and publishing the docs previews.
Task Description
There is no native way to safely allow builds for external contributors with the existing settings in Github.
It is possible to configure builds to require manual approval -- this does not pass the secrets to the forked repository, which in our case are necessary for the integration tests to run. This can be solved by using the
pull_request_target
event, but then it ignores anyapproval
you might have configured and directly builds the PR which is obviously dangerous.The only working "workaround" to this problem is to use
Environments
and configure theRequired reviewers
.After a careful review of the PR the build can then be approved and it will be executed as expected.
Tasks
The following tasks will need to be carried out:
Task Relationships
This task:
Useful Links
Help
The text was updated successfully, but these errors were encountered: