Issue 95: Use multipart upload API #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlspring
reviewed
Dec 8, 2020
src/main/java/org/carlspring/cloud/storage/s3fs/S3FileSystemProvider.java
Outdated
Show resolved
Hide resolved
carlspring
reviewed
Dec 8, 2020
src/main/java/org/carlspring/cloud/storage/s3fs/S3OutputStream.java
Outdated
Show resolved
Hide resolved
carlspring
reviewed
Dec 12, 2020
carlspring
changed the title
carlspring
approved these changes
Dec 12, 2020
|
Thanks for all your help! :) |
fixup! Issue 95: Use multipart upload API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This pull request closes #95.
The multipart upload API has been integrated. It's is designed to improve the upload experience for larger objects. You can upload an object in parts. These object parts can be uploaded independently, in any order, and in parallel. You can use a multipart upload for objects from 5 MB to 5 TB in size (according to Amazon S3 multipart upload limits).
S3OutputStreamuses multipart uploads to transfer data to S3 without storing it on local disk first.FileSystemProviderreturns this implementation for newOutputStreamsinstead ofS3SeekableByteChannelif possible.Acceptance Test
mvn clean install -Pintegration-testsstill works.Questions
Does this pull request break backward compatibility?
Does this pull request require other pull requests to be merged first?
Does this require an update of the documentation?