Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove UK overlays for Middlesex and Wiltshire #268

Merged
merged 2 commits into from
Aug 23, 2018
Merged

Remove UK overlays for Middlesex and Wiltshire #268

merged 2 commits into from
Aug 23, 2018

Conversation

manewitz
Copy link
Contributor

@manewitz manewitz commented Aug 14, 2018

This came up because we use carmen to populate a "subregion" dropdown that is loaded after a user selects a country. We had several people write in about the UK list not being accurate.

Middlesex is a "Historic County" and not ISO-recognized as a subregion. Wiltshire is a "Unitary Authority" and already in the base library. Even if their classifications had been corrent, the overlays removed had placed them at the wrong level in the region/subregion yaml hierarchy.

Before:

> uk = Carmen::Country.named('United Kingdom')
> uk.subregions.map(&:name).sort
=> [
    [0] "England",
    [1] "England and Wales",
    [2] "Great Britain",
    [3] "Middlesex",
    [4] "Northern Ireland",
    [5] "Scotland",
    [6] "United Kingdom",
    [7] "Wales; Cymru",
    [8] "Wiltshire"
]

After:

> uk.subregions.map(&:name).sort
=> [
     [0] "England",
     [1] "England and Wales",
     [2] "Great Britain",
     [3] "Northern Ireland",
     [4] "Scotland",
     [5] "United Kingdom",
     [6] "Wales; Cymru",
   ]

Before submitting the PR please make sure that you have done the following:

@manewitz
Copy link
Contributor Author

@swcraig let me know how this looks when you have some bandwidth

@swcraig
Copy link
Collaborator

swcraig commented Aug 22, 2018

Thanks for the PR! I will take a closer look tomorrow.

Copy link
Collaborator

@swcraig swcraig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @manewitz. This looks great. I added a commit to resolve a merge conflict with the CHANGELOG I created by merging #267.

@swcraig swcraig merged commit 3c77660 into carmen-ruby:master Aug 23, 2018
@manewitz
Copy link
Contributor Author

manewitz commented Aug 23, 2018

(airhorn intensifies) Thank you!

@manewitz
Copy link
Contributor Author

@swcraig any reason you are holding on pushing out the new version?

@swcraig
Copy link
Collaborator

swcraig commented May 3, 2019

@manewitz No particular reason, the new version is out now. I'll work on a more consistent release schedule going forward. Thanks again for the contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants