Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI --interpret-escapes works without --title specified #471

Merged
merged 2 commits into from
Oct 30, 2021

Conversation

caronc
Copy link
Owner

@caronc caronc commented Oct 26, 2021

Description:

Related issue (if applicable): #457

It was observed that the --interpret-escapes (-e) switch does not work on the CLI if no --title (-t) is specified.

This should never have been the case and is fixed in this PR.

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • No lint errors (use flake8)
  • 100% test coverage

@codecov-commenter
Copy link

codecov-commenter commented Oct 27, 2021

Codecov Report

Merging #471 (902e45b) into master (ea75bb9) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #471   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           97        97           
  Lines        12596     12597    +1     
  Branches      2138      2139    +1     
=========================================
+ Hits         12596     12597    +1     
Impacted Files Coverage Δ
apprise/Apprise.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea75bb9...902e45b. Read the comment docs.

@caronc caronc merged commit 9b5815e into master Oct 30, 2021
@caronc caronc deleted the 452-escape-missing-titles branch November 11, 2021 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants