Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggession for Dynamic Label Count Change #14

Open
ErAshu opened this issue Aug 6, 2017 · 6 comments
Open

Suggession for Dynamic Label Count Change #14

ErAshu opened this issue Aug 6, 2017 · 6 comments

Comments

@ErAshu
Copy link

ErAshu commented Aug 6, 2017

Hello,
I found a minor issue. I set the max selection 10.
let allowedSelections: ImagePickerSelection? = .limit(to: 10)

It should be reflect on CarousellImagePickerController Subtitle. See Screenshot.

img_0363

@shujin
Copy link
Contributor

shujin commented Aug 7, 2017

Good catch! Would you like to submit a PR for this? :)

@ErAshu
Copy link
Author

ErAshu commented Aug 9, 2017

One more thing, i want to change the content and image of this. Please guide from where i can do this?
8b2ea10f-3be1-4562-b17a-4d0c4b52c344

@bcylin
Copy link
Contributor

bcylin commented Aug 9, 2017

The hint text is not related to the ImagePickerSelection, it's a separated property which can be set to any NSAttributedString.

The customization for the screen of PHAuthorizationStatus.denied requires some modifications to override the behaviour in handle(photoLibraryPermission:). One of the solutions for now might be showing a different screen based on the authorization status:

switch PHPhotoLibrary.authorizationStatus() {
  case .notDetermined:
    // ask for the permission
  case .authorized:
    // only present the image picker when the permission is granted
    present(ImagePickerController(selectedAssets: []), animated: true, completion: nil)
  case .denied, .restricted:
    // present the customized screen
}

@ErAshu
Copy link
Author

ErAshu commented Aug 9, 2017

This is exactly i want. In which variable i have to pass the text and image. Please tell me the file name. Actually i have to place a button to open App Settings screen.

@bcylin
Copy link
Contributor

bcylin commented Aug 9, 2017

That should be inside your class where you initialize the Pickle.ImagePickerController and present it. There isn't a variable for this customization yet. The workaround is to present your own customized view controller when the permission is .denied or .restricted.

@ErAshu
Copy link
Author

ErAshu commented Nov 17, 2017

How to pass selectionsLimit and hint text from viewController?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants