Use constant for configuring limit #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hydralisk01, can you review this pull request? |
bcylin
approved these changes
Oct 18, 2017
| @@ -47,7 +49,7 @@ internal class CarousellImagePickerController: ImagePickerController { | |||
| ) | |||
|
|
|||
| let subtitle = NSAttributedString( | |||
| string: "You can choose up to 4 photos for your listing.\n", | |||
| string: "You can choose up to \(selectionsLimit) photos for your listing.\n", | |||
There was a problem hiding this comment.
Looks like a good idea! Does it need a .stringsdict in the example for both singular and plural photos?
There was a problem hiding this comment.
How to pass selectionsLimit and hint text from viewController?
|
How to pass selectionsLimit and hint text from viewController? |
|
Hint text is set via the |
Generated by 🚫 Danger |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid confusion e.g. #14.