Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swift 4 #15

Merged
merged 9 commits into from
Jan 4, 2018
Merged

Swift 4 #15

merged 9 commits into from
Jan 4, 2018

Conversation

bcylin
Copy link
Contributor

@bcylin bcylin commented Sep 15, 2017

  • Use NSAttributedStringKey in string attributes
  • Update to Xcode 9 settings with CocoaPods 1.3.1
  • Update UI tests in Xcode 9

@bcylin bcylin requested a review from tflhyl December 14, 2017 10:10
@shujin shujin merged commit 6dd1462 into carousell:master Jan 4, 2018
@bcylin bcylin deleted the feature/swift-4 branch January 10, 2018 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shujin shujin shujin approved these changes

@tflhyl tflhyl Awaiting requested review from tflhyl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bcylin @shujin