Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix iOS 11 permission issue #17

Closed
wants to merge 4 commits into from
Closed

Fix iOS 11 permission issue #17

wants to merge 4 commits into from

Conversation

daveluong
Copy link
Contributor

@daveluong daveluong commented Oct 6, 2017 •
edited
Loading

  • Add delegate callback when no permission is granted
  • Remove unused systemPhotoLibraryController

Refer to issue #16

@carouselljenkins
Copy link

@amelia2801, can you review this pull request?

@daveluong daveluong requested a review from tflhyl October 6, 2017 03:31
@bcylin
Copy link
Contributor

bcylin commented Oct 6, 2017

Since the permission denied case will be handled externally, would it be more straightforward to check the PHPhotoLibrary.authorizationStatus() before Pickle.ImagePickerController is presented?

@daveluong
Copy link
Contributor Author

@bcylin Agree, that'd be easier. Will be closing this PR

@daveluong daveluong closed this Oct 6, 2017
@daveluong daveluong deleted the feature/fix-io11-permission-issue branch October 6, 2017 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tflhyl tflhyl Awaiting requested review from tflhyl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daveluong @carouselljenkins @bcylin