3D Touch Photo Preview #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcylin
force-pushed
the
feature/photo-preview
branch
from
6a1d5f2 to
1e871bf
Compare
jianyaoang
reviewed
May 15, 2017
| @@ -72,9 +72,9 @@ internal class PhotoGalleryViewController: UIViewController, | |||
|
|
|||
| private let album: PHAssetCollection | |||
| private let configuration: ImagePickerConfigurable? | |||
| private lazy var isCameraCompatible: Bool = self.album.isCameraCompatible | |||
| private(set) lazy var isCameraCompatible: Bool = self.album.isCameraCompatible | |||
There was a problem hiding this comment.
@bcylin reminder to add internal
There was a problem hiding this comment.
Updated with internal, thanks!
bcylin
force-pushed
the
feature/photo-preview
branch
from
1e871bf to
0dd9ed1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PhotoDetailViewControllerfor displaying photo previewPhotoGalleryViewControllertoUIViewControllerPreviewingDelegateMain.storyboardfrom the example project