Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Project Directories #34

Merged
merged 2 commits into from
Apr 4, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -51,14 +51,12 @@ playground.xcworkspace
# you should judge for yourself, the pros and cons are mentioned at:
# https://guides.cocoapods.org/using/using-cocoapods.html#should-i-check-the-pods-directory-into-source-control
#
# Pods/
Pods

Pods-*
Local Podspecs
Manifest.lock

*/Pods/SwiftLint

# Carthage
#
# Add this line if you want to avoid checking in source code from Carthage dependencies.
Expand Down
2 changes: 1 addition & 1 deletion .jazzy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ author: Carousell
author_url: https://github.com/carousell
github_url: https://github.com/carousell/pickle
github_file_prefix: https://github.com/carousell/pickle/blob/master
xcodebuild_arguments: [-project, Example/Pods/Pods.xcodeproj, -scheme, Pickle]
xcodebuild_arguments: [-project, Pickle.xcodeproj, -scheme, Pickle]
module: Pickle
module_version: 1.3.1
output: docs/output
Expand Down
3 changes: 2 additions & 1 deletion Example/.swiftlint.yml → .swiftlint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ identifier_name:
- pi
- to
included:
- ../Pickle
- Example
- Pickle
excluded:
- Pods
4 changes: 2 additions & 2 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,13 @@ cache:
cocoapods: true
directories:
- vendor/bundle
- Example/Pods/SwiftLint
- Pods
before_install:
- xcrun instruments -s devices
- xcrun instruments -w "iPhone X (12.0) [" || true
install:
- bundle install --jobs=3 --retry=3 --deployment
- bundle exec pod install --project-directory=Example
- bundle exec pod install
- sh scripts/install-carthage.sh 0.27.0
before_script:
- if [ -n "$DANGER_GITHUB_API_TOKEN" ]; then bundle exec danger; fi
Expand Down
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
# Change Log

## v1.4.0

* Swift 4.2
* Move the framework and example targets into a single project

## v1.3.1

* Update the project to Xcode 10 [#26](https://github.com/carousell/pickle/pull/26)
Expand Down
6 changes: 3 additions & 3 deletions Dangerfile
Original file line number Diff line number Diff line change
Expand Up @@ -31,13 +31,13 @@ if reviewer && !assigned
end

# Run swiftlint
%x(echo "reporter: json" >> Example/.swiftlint.yml)
%x(echo "reporter: json" >> .swiftlint.yml)

pwd = Dir.pwd + "/"
linter_json = %x(cd Example && #{pwd}Example/Pods/SwiftLint/swiftlint && cd --)
linter_json = %x(#{pwd}/Pods/SwiftLint/swiftlint)
results = JSON.parse linter_json

%x(git checkout Example/.swiftlint.yml)
%x(git checkout .swiftlint.yml)

results.each do |violation|
file = violation["file"].gsub(pwd, "")
Expand Down
File renamed without changes.
File renamed without changes.
588 changes: 0 additions & 588 deletions Example/Pickle.xcodeproj/project.pbxproj

This file was deleted.

916 changes: 0 additions & 916 deletions Example/Pods/Pods.xcodeproj/project.pbxproj

This file was deleted.

This file was deleted.

71 changes: 0 additions & 71 deletions Example/Pods/Pods.xcodeproj/xcshareddata/xcschemes/Pickle.xcscheme

This file was deleted.

26 changes: 0 additions & 26 deletions Example/Pods/Target Support Files/Pickle/Info.plist

This file was deleted.

5 changes: 0 additions & 5 deletions Example/Pods/Target Support Files/Pickle/Pickle-dummy.m

This file was deleted.

12 changes: 0 additions & 12 deletions Example/Pods/Target Support Files/Pickle/Pickle-prefix.pch

This file was deleted.

16 changes: 0 additions & 16 deletions Example/Pods/Target Support Files/Pickle/Pickle-umbrella.h

This file was deleted.

6 changes: 0 additions & 6 deletions Example/Pods/Target Support Files/Pickle/Pickle.modulemap

This file was deleted.

10 changes: 0 additions & 10 deletions Example/Pods/Target Support Files/Pickle/Pickle.xcconfig

This file was deleted.

File renamed without changes.
9 changes: 3 additions & 6 deletions Makefile
Original file line number Diff line number Diff line change
@@ -1,15 +1,12 @@
bootstrap:
pod install --project-directory=Example && open Example/Pickle.xcworkspace

pod-install:
pod install --project-directory=Example
pod install && open Pickle.xcworkspace

build:
set -o pipefail && xcodebuild -workspace Example/Pickle.xcworkspace -scheme Pickle clean build | bundle exec xcpretty -c
set -o pipefail && xcodebuild -workspace Pickle.xcworkspace -scheme Pickle clean build | bundle exec xcpretty -c

test:
set -o pipefail && xcodebuild \
-workspace Example/Pickle.xcworkspace \
-workspace Pickle.xcworkspace \
-scheme Pickle-Example \
-destination 'platform=iOS Simulator,name=iPhone X,OS=12.0' \
CODE_SIGN_IDENTITY="" CODE_SIGNING_REQUIRED=NO \
Expand Down
1 change: 0 additions & 1 deletion Pickle.xcodeproj

This file was deleted.

Loading