Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Live Preview #39
Live Preview #39
Changes from 23 commits
87f2273
f502787
ed2b84e
d52ddce
faddd5f
7c762bd
c16a310
23498fb
f485fbb
88db04e
d05ca38
3f1cbfd
d0a003e
5d4a624
cfd9113
4682bb9
fd69328
e1deb1e
dc7d981
929302a
4e6e808
680c6e6
28d2ed4
9ae0bf8
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Accessing
AVCaptureDeviceInput
in the initializer will prematurely prompt user for permission, so I have moved it tostartSession()
instead. We only use the live view when user has already granted permission previouslyThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It'd be good to have the documentation of this method, also worth mentioning that this method won't trigger the
didSelect
anddidDeselectImageAsset
delegate methods.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have updated README
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be
imagePickerControllerdidFinishLaunchingCamera(_:)
since theselectedAssets
is now accessible fromImagePickerController
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh no, I have changed it back to
private
since we already have this delegate