Support CarrierWave 3.x #215
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add spec/tmp to .gitignore - Fix warning 'Invalid update document provided' - Set files before testing behavior of #remove_uploaders= and #remove_uploader - Make sure to reset value of #remove_previously_stored_files_after_update
As CarrierWave 3.0 introduced filename deduplication, it will prevent mistakenly removing the newly-uploaded file in a different way.
mshibuya
commented
Jan 13, 2025
| if Gem::Version.new(CarrierWave::VERSION) >= Gem::Version.new("3.0.beta") | ||
| include CarrierWave3 | ||
| else | ||
| include CarrierWavePre3 | ||
| end |
There was a problem hiding this comment.
Changes in this file can be better understood by using ?w=1.
What I did was introducing new modules CarrierWave3 and CarrierWavePre3, and conditionally include one of them based on the CarrierWave version.
mshibuya
commented
Jan 13, 2025
| end | ||
| end | ||
| } | ||
| end |
There was a problem hiding this comment.
carrierwave-mongoid was heavily affected by the issue in carrierwave: carrierwaveuploader/carrierwave#2770. The issue is hard to investigate due to its nature, and affected many carrierwave versions (from 3.0.0 to 3.1.0). Hence I've added a monkey patch here, to ensure carrierwave-mongoid works with flawed carrierwave versions.
|
@rmm5t Hi! Any chance you can take a look at this? 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to make carrierwave-mongoid to work with CarrierWave 3.x, while keeping the support for older CarrierWave versions. Changes are separeted into several commits, to describe the intention better.