-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add espresso-dev-node to SDK #81
Merged
endersonmaia
merged 3 commits into
prerelease/v2-alpha
from
feature/add-espresso-dev-node-to-sdk
Jan 23, 2025
Merged
Add espresso-dev-node to SDK #81
endersonmaia
merged 3 commits into
prerelease/v2-alpha
from
feature/add-espresso-dev-node-to-sdk
Jan 23, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 92e1037 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
tuler
reviewed
Oct 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo in the commit message
endersonmaia
force-pushed
the
feature/add-espresso-dev-node-to-sdk
branch
from
October 1, 2024 16:45
aec4567
to
bfe1fd4
Compare
endersonmaia
force-pushed
the
feature/add-espresso-dev-node-to-sdk
branch
from
January 22, 2025 14:56
bfe1fd4
to
28e9fce
Compare
endersonmaia
force-pushed
the
feature/add-espresso-dev-node-to-sdk
branch
from
January 22, 2025 21:18
28e9fce
to
9dc6320
Compare
tuler
reviewed
Jan 22, 2025
tuler
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces the
espresso-dev-node
binary to the Cartesi SDK, including updates to the Dockerfile and configuration files to support this addition. The most important changes are summarized below:New Feature Addition:
.changeset/strong-walls-help.md
: Added a changeset note indicating the addition of theespresso-dev-node
binary to the SDK. ([.changeset/strong-walls-help.mdR1-R5](https://github.com/cartesi/cli/pull/81/files#diff-5ff7ded5e9ae647f2ff4df76bfd2de2ef3f77778412a303745f4feab719752c3R1-R5)
)Dockerfile Updates:
packages/sdk/Dockerfile
: Introduced theESPRESSO_DEV_NODE_TAG
argument and added a new stage to pull theespresso-dev-node
binary from the Espresso Systems GitHub container registry. ([packages/sdk/DockerfileR9-R12](https://github.com/cartesi/cli/pull/81/files#diff-fbbb6309bd1c5bde85dc9baab5c5c1ef5af52fedb5e3fd28cecf37916d3ef1feR9-R12)
)packages/sdk/Dockerfile
: Updated the Dockerfile to copy theespresso-dev-node
binary into/usr/bin/
. ([packages/sdk/DockerfileR152-R153](https://github.com/cartesi/cli/pull/81/files#diff-fbbb6309bd1c5bde85dc9baab5c5c1ef5af52fedb5e3fd28cecf37916d3ef1feR152-R153)
)Configuration Updates:
packages/sdk/docker-bake.hcl
: Added theESPRESSO_DEV_NODE_TAG
variable to the default target configuration. ([packages/sdk/docker-bake.hclR17](https://github.com/cartesi/cli/pull/81/files#diff-f31033306f300af23520856c404681eb6cbe45d9f28ce0f28abb24fcae811e5bR17)
)