Reuse transport when talking with registries #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaopapereira
force-pushed
the
multiple-auth-requests-imgpkg
branch
from
24e6fda to
c54ded9
Compare
cppforlife
reviewed
Feb 23, 2022
By reusing the same transport when talking to the registries imgpkg doesn't need to retrieve the oauth token everytime a request is made to the registry Signed-off-by: Joao Pereira <[email protected]>
joaopapereira
force-pushed
the
multiple-auth-requests-imgpkg
branch
from
c54ded9 to
df3f7f0
Compare
|
lgtm |
27 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds makes an improvement on the communication with the registries. Previously for each request done to the registry, a new transport was created. The main issue is that the authentication part was lost between requests.
We are introducing a store that will maintain the transport information that will be reused whenever possible, this will lower the number of times that
imgpkgneeds to talk with authentication servers.