Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

version constraints consider build metadata to be meaningful #1338

Open
cjnosal opened this issue Sep 29, 2023 · 2 comments
Open

version constraints consider build metadata to be meaningful #1338

cjnosal opened this issue Sep 29, 2023 · 2 comments
Labels
bug This issue describes a defect or unexpected behavior carvel-triage This issue has not yet been reviewed for validity discussion This issue is not a bug or feature and a conversation is needed to find an appropriate resolution

Comments

@cjnosal
Copy link

cjnosal commented Sep 29, 2023

What steps did you take:
Deploy a Package with version 0.0.0+build.1234
Deploy a PackageInstall with version constraint 0.0.0

What happened:
The PackageInstall could not find a matching version

What did you expect:
Build metadata is ignored in the version comparison following the Semver 2.0.0 spec and the PackageInstall successfully reconciles.

Anything else you would like to add:
https://github.com/carvel-dev/semver/ (included via vendir) is used for version comparisons. (Issues aren't enabled on semver repo)
carvel-dev/semver#1 added Build Metadata to the Compare function for deterministic sort. As Compare is also wrapped by all the LT/GT/EQ/NE functions this has the side effect that "0.0.0".EQ("0.0.0+123") changed from true to false.
https://github.com/carvel-dev/semver/blob/master/v4/semver_test.go#L154 still states that build should be ignored, but the test implementations assert that it is not ignored.

Environment:

  • kapp Controller version (execute kubectl get deployment -n kapp-controller kapp-controller -o yaml and the annotation is kbld.k14s.io/images): v0.44.1
  • Kubernetes version (use kubectl version): 1.26.6

Vote on this request

This is an invitation to the community to vote on issues, to help us prioritize our backlog. Use the "smiley face" up to the right of this comment to vote.

👍 "I would like to see this addressed as soon as possible"
👎 "There are other more important things to focus on right now"

We are also happy to receive and review Pull Requests if you want to help working on this issue.

@cjnosal cjnosal added bug This issue describes a defect or unexpected behavior carvel-triage This issue has not yet been reviewed for validity labels Sep 29, 2023
Copy link

github-actions bot commented Nov 9, 2023

This issue is being marked as stale due to a long period of inactivity and will be closed in 5 days if there is no response.

@github-actions github-actions bot added the stale This issue has had no activity for a while and will be closed soon label Nov 9, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 14, 2023
@github-project-automation github-project-automation bot moved this to Closed in Carvel Nov 14, 2023
@praveenrewar praveenrewar removed the stale This issue has had no activity for a while and will be closed soon label Feb 6, 2024
@praveenrewar praveenrewar reopened this Feb 6, 2024
@github-project-automation github-project-automation bot moved this from Closed to In Progress in Carvel Feb 6, 2024
Copy link

This issue is being marked as stale due to a long period of inactivity and will be closed in 5 days if there is no response.

@github-actions github-actions bot added the stale This issue has had no activity for a while and will be closed soon label Mar 18, 2024
@praveenrewar praveenrewar added discussion This issue is not a bug or feature and a conversation is needed to find an appropriate resolution and removed stale This issue has had no activity for a while and will be closed soon labels Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue describes a defect or unexpected behavior carvel-triage This issue has not yet been reviewed for validity discussion This issue is not a bug or feature and a conversation is needed to find an appropriate resolution
Projects
Archived in project
Development

No branches or pull requests

2 participants