Ignore build metadata for sort order #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use sort.Stable for repeatable sorts of semantically-equal versions Signed-off-by: Conor Nosal <[email protected]>
cjnosal
force-pushed
the
stable-sort-buildmeta
branch
from
410ce6b
to
eed0ea3
Compare
|
Thank you so much for the PR @xtreme-conor-nosal! This seems like a reasonable change to me and the PR looks good to me too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use sort.Stable for repeatable sorts of semantically-equal versions
Build metadata MUST be ignored when determining version precedence
https://semver.org/spec/v2.0.0.html#spec-item-10
related: carvel-dev/kapp-controller#1338