remove admin burn from catalog contract #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ENG-443 remove admin burn from catalog contract
Scope of Work:
Completion Criteria:
|
reefloretto
reviewed
Mar 2, 2022
| (msg.sender == tokenData[_tokenId].creator && msg.sender == ownerOf(_tokenId)) || msg.sender == owner(), | ||
| "Only creator or Admin" | ||
| ); | ||
| require((msg.sender == tokenData[_tokenId].creator && msg.sender == ownerOf(_tokenId)), "Only creator"); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linear Issue: ENG-443
DESCRIPTION
This PR introduces the removal of admin burn from the Catalog shared creator contract. It also includes some spring cleaning, removing unneeded contracts, scripts, and tests used in early development. Tests have been updated accordingly.
The deployed
Catalogrinkeby proxy contract has been upgraded to the latest deployed implementation, andcatalog-contractsversion0.1.4has been published including these changes.HOW TO TEST
Ensure all checks pass. Perform sanity checks on deployed contract state (data is still readable).