build: fixing blacklist/whitelist to use package names instead of paths #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbohren
force-pushed
the
fix-blacklist-pkg-name-vs-path
branch
from
b83dd32 to
8607a2d
Compare
| packages_to_be_built_deps = [ | ||
| p for p in packages_to_be_built_deps if (p[0] not in context.blacklist or p[0] in packages)] | ||
| p for p in packages_to_be_built_deps if (p[1].name not in context.blacklist or p[1].name in packages)] |
There was a problem hiding this comment.
It would probably be better to expand the tuple rather than access it by index. Something like:
[(pth, pkg) for pth, pkg in packages_to_be_built_deps if pkg.name not in context.blacklist or pkg.name in packages]
|
Other than the comment lgtm. |
jbohren
force-pushed
the
fix-blacklist-pkg-name-vs-path
branch
5 times, most recently
from
1ec7683 to
783ed38
Compare
…ackages Also changing `--clear-*list` to `--no-*list` to be more consistent and clearer.
jbohren
force-pushed
the
fix-blacklist-pkg-name-vs-path
branch
from
783ed38 to
ebca78a
Compare
|
@wjwwood This is good to review. |
wjwwood
added a commit
that referenced
this pull request
Apr 2, 2015
…path build: fixing blacklist/whitelist to use package names instead of paths
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue: #152 (comment)
Fixes confusion: #152 (comment)