Add fjall 2.5 to benchmark suite #944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cberner
requested changes
Feb 4, 2025
|
Anything to fix/change? @marvin-j97 |
cberner
approved these changes
Feb 4, 2025
You are not setting the block cache, so it will repeatedly decompress read data. Also you disabled compression (because the feature flag is not set), while RocksDB uses the default compression (snappy). I would probably set both to LZ4. |
|
@cberner If these changes look good to you, you can merge |
|
Oh wait let me fix mac build first |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was curious about how redb fairs against fjall.
Others might be as well