JsonObjectConverter: Ignore all final backing-fields #298
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Assume a class, that has two constructors (see test
TwoConstructorsWithFinalField
):When instantiated using Klaxon from JSON, the final fields of the primary constructor can not be filled , which may result in a non-neccessary Exception.
java.lang.IllegalArgumentException: Can not set final {{typeX}} field {{...}} to {{typeX or typeY}}
Solution:
Ignore final fields after instantiating the class in Klaxon object converter.
Reasoning:
Final fields can not be set to a new value.
All final fields can be ignored by Klaxon after instantiation, because (in JVM) they must have already been initialized during construction of the object.