-
Notifications
You must be signed in to change notification settings - Fork 129
Restore publishing scripts for continuous delivery #966
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's please take care to work on only a single task or at most a couple of tasks in a single pull request. We are including changes from too many issues here, so the pull request is losing focus.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm converting this pull request to draft status since there is still work in progress. 😃 Please request a review once the previous review issues are resolved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the scope of issue #964 is limited to deployment/publication scripts, this pull request should only include changes that are related to the "continuous delivery" files cd-*.yml
Let's move changes related to continuous integration (ci-*.yml
) to a separate pull request after claiming the relevant issue.
In this way, our work is a bit easier to follow and less error-prone. It will also be clear to other contributors who is working on which task(s).
Co-authored-by: Brylie Christopher Oxley <[email protected]>
Co-authored-by: Brylie Christopher Oxley <[email protected]>
Co-authored-by: Brylie Christopher Oxley <[email protected]>
@MuluhGodson, great work so far. I'm just commenting mainly to keep things slightly more separated since some of the tasks have different sizes and goals. |
@brylie thank you. It's my pleasure |
Fixes
Closes #964 by @brylie
Description
This PR restores the scripts used to deploy the packages to NPM. The
sed
command, I left it in place after testing and previewing a verbose output of what it does, which is ensuring that for each package deployed, there is a README.md file in the dist folder.Closes #964
Checklist
Update index.md
).main
ormaster
).visible errors.
Developer Certificate of Origin
Developer Certificate of Origin