Skip to content
This repository has been archived by the owner on Apr 30, 2024. It is now read-only.

Restore publishing scripts for continuous delivery #966

Merged
merged 18 commits into from
Oct 13, 2021
Merged

Restore publishing scripts for continuous delivery #966

merged 18 commits into from
Oct 13, 2021

Conversation

MuluhGodson
Copy link
Contributor

@MuluhGodson MuluhGodson commented Oct 12, 2021

Fixes

Closes #964 by @brylie

Description

This PR restores the scripts used to deploy the packages to NPM. The sed command, I left it in place after testing and previewing a verbose output of what it does, which is ensuring that for each package deployed, there is a README.md file in the dist folder.

Closes #964

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • [x ] I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@MuluhGodson MuluhGodson requested review from a team as code owners October 12, 2021 09:54
@MuluhGodson MuluhGodson requested review from Dhruvi16, zackkrida and hugosolar and removed request for a team October 12, 2021 09:54
.github/workflows/cd-fonts.yml Show resolved Hide resolved
.github/workflows/cd-vocabulary.yml Show resolved Hide resolved
.github/workflows/cd-vue.yml Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
deploy.sh Show resolved Hide resolved
deploy.sh Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
publish.sh Show resolved Hide resolved
Copy link
Contributor

@brylie brylie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's please take care to work on only a single task or at most a couple of tasks in a single pull request. We are including changes from too many issues here, so the pull request is losing focus.

Copy link
Contributor

@brylie brylie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the checklist items in the pull request description. There should be no space before or after the "x". It is possible to just click the checkmark rather than manually entering the "x" within the square brackets.

image

@brylie brylie marked this pull request as draft October 12, 2021 11:01
@brylie
Copy link
Contributor

brylie commented Oct 12, 2021

I'm converting this pull request to draft status since there is still work in progress. 😃

Please request a review once the previous review issues are resolved.

publish/fonts.sh Outdated Show resolved Hide resolved
publish/vocabulary.sh Outdated Show resolved Hide resolved
publish/vue-vocabulary.sh Outdated Show resolved Hide resolved
Copy link
Contributor

@brylie brylie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the scope of issue #964 is limited to deployment/publication scripts, this pull request should only include changes that are related to the "continuous delivery" files cd-*.yml

Let's move changes related to continuous integration (ci-*.yml) to a separate pull request after claiming the relevant issue.

In this way, our work is a bit easier to follow and less error-prone. It will also be clear to other contributors who is working on which task(s).

.github/workflows/ci-fonts.yml Outdated Show resolved Hide resolved
.github/workflows/ci-vue.yml Outdated Show resolved Hide resolved
deploy.sh Show resolved Hide resolved
publish.sh Show resolved Hide resolved
@brylie
Copy link
Contributor

brylie commented Oct 13, 2021

@MuluhGodson, great work so far. I'm just commenting mainly to keep things slightly more separated since some of the tasks have different sizes and goals.

@MuluhGodson MuluhGodson marked this pull request as ready for review October 13, 2021 08:34
@MuluhGodson
Copy link
Contributor Author

@brylie thank you. It's my pleasure

@brylie brylie changed the title Updating the Gihub Actions scripts to reflect current repository structure. Restore publishing scripts for continuous delivery Oct 13, 2021
@brylie brylie merged commit 438aac5 into cc-archive:main Oct 13, 2021
@brylie brylie self-assigned this Oct 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Restore deployment scripts for all packages
2 participants