Fix missing geography_id for triads
#76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeancochrane
approved these changes
Dec 20, 2024
pipeline/03-evaluate.R
Outdated
Comment on lines
263
to
267
| geography_id = ifelse( | ||
| is.na(geography_id) & geography_type == "triad_code", | ||
| triad_code, | ||
| geography_id | ||
| ) |
There was a problem hiding this comment.
[Question, non-blocking] Isn't this basically what add_triad_code is doing? Also, do we need the geography_type check in add_triad_code too?
There was a problem hiding this comment.
Whoops, nice catch. I left this in from an earlier iteration of trying to solve this fix. This is why we code review. Fixed in 89de3ae.
Damonamajor
pushed a commit
that referenced
this pull request
Jan 14, 2025
* Fix missing geography_id for triads * Remove geography_id in mutate()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as ccao-data/model-res-avm#299.