Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5.1.3 library version does not resolve correctly .env file location in jar file. #38

Closed
Michal-SG opened this issue Mar 10, 2020 · 3 comments
Labels

Comments

@Michal-SG
Copy link

Michal-SG commented Mar 10, 2020

Steps to reproduce:

  • checkout project: https://github.com/cdimascio/kotlin-spring-mvc-template

  • replace 3.1.3 library version with 5.1.3

  • create .env file under src/main/resources

  • verify that running gradle bootRun command resolves .env file location correctly.
    image

  • verify that running gradle bootJar && java -jar build/libs/example-service-1.0.0.jar doesn't resolve .env files location properly
    image

Tested also with 3.1.3 version and it was working correctly back then.

Update:
Last working version: 3.1.4
First not working version: 3.1.5

@Michal-SG
Copy link
Author

Haven't spotted difference in jar structure. In both cases (3.1.3 & 5.1.3) .env file is located in BOOT-INF/classes directory

@cdimascio cdimascio added the bug label Mar 11, 2020
@cdimascio
Copy link
Owner

cdimascio commented Mar 11, 2020

@Michal-SG Thanks for the issue. I published a new version, 5.1.4 with the fix.

Note, it can sometimes take 24 hours for the jar to propagate to mavencentral. that being said, it should be available on jcenter now

Let me know how it goes

@Michal-SG
Copy link
Author

Thanks @cdimascio for quick action. Today verified issue with newest library version and it seems to not be the case anymore. Dziekuje!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants