test(express-5): change routes in tests to new path route syntax #1036
+10
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SF97
force-pushed
the
fix-failing-tests
branch
2 times, most recently
from
9a2857c to
6f174ea
Compare
SF97
force-pushed
the
fix-failing-tests
branch
from
6f174ea to
b023e41
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #969, there are several failing tests when testing this lib against express 5. One of the reasons some tests are failing is due to the fact that express 5 changed its routing syntax, which made some tests fail in the "beforeAll" hook. This MR fixes some of them
There are still some tests that use wildcard syntax that break, but I haven't found a way to get around them just yet. I'll continue to investigate it, but it can be merged in another PR