fix: region and account not being set in certain monitoring metrics #614
+8
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgrades project dependencies. See details in [workflow run]. [Workflow Run]: https://github.com/cdklabs/cdk-monitoring-constructs/actions/runs/12226655446 ------ *Automatically created by projen via the "upgrade-main" workflow*
The adaptMetric function does not take the globalDefault account or region into account only the period This change checks whether there is a global default for either and if so adds it into the metric [Testing] All test cases pass, validated that global default is passed into cloud formation template and dashboard [Reviewers]: Maintainer: userid [Code Review]:
umardab-amzn
changed the title
umardab-amzn
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes global default region and account not being set in certain monitoring metrics by adding them in the adaptMetric function
Tests pass
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license