-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cypress test for redirector theme, unskip most tests #572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcraig3
force-pushed
the
fix-broken-drafts-and-cypress-3
branch
from
February 16, 2022 21:01
1c76863
to
5e1840a
Compare
pcraig3
force-pushed
the
fix-broken-drafts-and-cypress-3
branch
from
February 16, 2022 22:06
687127f
to
cd643d7
Compare
pcraig3
changed the title
[WIP] Fix broken drafts and cypress 3
Add cypress test for redirector theme, unskip most tests
Feb 17, 2022
I re-wrote the test to try and get it working, but it didn't help, so reverting to the original one.
timarney
approved these changes
Feb 17, 2022
Thanks for pushing through on this one @pcraig3 . This gets us back to a nicer spot :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR:
New test for Redirector
This PR adds a cypress test for our Redirector theme. The new test:
To add this new test, I've modified the
test-setup
command to be able to change themes. It now will always run, setting the theme tocds-default
, unless a different theme is passed in.Unskip previously skipped tests tests
All of the previously
skip
ed tests now work again, so I've unskipped them.In particular:
track.login.panel.spec.js
user.add.spec.js
user.collections.panel.spec.js
And the
settings.page
tests I was having trouble with are working too.Skip the alert tests
Not everything works though. For some reason, the
alert
test stopped passing, so now it's the only test that consistently fails on CI. I don't really know why it's happening and the screenshots aren't helpful (they say it can't find an input field even though it looks like it's on the screen).Skipping this tests makes everything else go green. It sucks, but this is still an improvement over what we had before.
Update cypress
Move from
8.4.1
to9.5.0
.Use 5.9 by default in
wp-env
Seems to work just fine, so let's use it. I suspect using the older version of wordpress was what was causing our previous test failures.