Add support to display FR column headings in reports CSVs

[whabanks]

Summary | Résumé

This PR adds support for displaying French translated column headers in downloaded report CSVs. It also cleans up the headers for consistency, converting email_address and phone_number to Email address and Phone number for consistent case and styling in the headings.

Test instructions | Instructions pour tester la modification

Test 1 - Basic sends

1. Create and send two bulk sends, one Email and one SMS
2. Navigate to the jobs page and switch the language to French
3. Download the report
4. Note that the column headings are in French and the case and spacing for email address and phone number are correct
5. Note that the column values for Status and Type are in French

Test 2 - Custom columns

1. Create and send two bulk sends, one Email and one SMS both with custom headings
2. Navigate to the jobs page and switch the language to French
3. Download the report
4. Note that the column headings are in French and the Case and spacing for email address and phone number are correct
5. Note that custom column headings are preserved as they were input by the user

Test Downloaded CSVs

1. Open both an SMS and Email CSV in MS Excel.
2. Note that accented characters are rendered properly
3. Check for any other encoding issues related to accented FR characters.

[github-actions]

🧪 Review environment

https://6wcz6kj3psvc6lfrqattc7sxeu0tjexb.lambda-url.ca-central-1.on.aws/

[andrewleith]

Looks great. Tested and scenarios come out as described!

One side note (probably outside the scope of this PR) is that when you open up these CSV files in excel, the french characters get garbled and it looks pretty rough. It seems like excel doesnt think the file is in the right encoding:

[andrewleith]

One side note (probably outside the scope of this PR) is that when you open up these CSV files in excel, the french characters get garbled and it looks pretty rough. It seems like excel doesnt think the file is in the right encoding:

For future work: I was playing around trying to fix this and it seems like if you yield the BOM before the rest of the CSV content this gets fixed, not sure if there are any negative side effects though. I added the following line to utils.py/generate_notifications_csv(): yield u'\uFEFF'.encode('utf-8') before the first yield statement.

Source: https://stackoverflow.com/questions/37013433/proper-rendering-of-flask-produced-csv-files-in-excel

[whabanks]

One side note (probably outside the scope of this PR) is that when you open up these CSV files in excel, the french characters get garbled and it looks pretty rough. It seems like excel doesnt think the file is in the right encoding:

For future work: I was playing around trying to fix this and it seems like if you yield the BOM before the rest of the CSV content this gets fixed, not sure if there are any negative side effects though. I added the following line to utils.py/generate_notifications_csv(): yield u'\uFEFF'.encode('utf-8') before the first yield statement.

Source: https://stackoverflow.com/questions/37013433/proper-rendering-of-flask-produced-csv-files-in-excel

Sweet catch, I will play around with this - having garbled text like that is less than ideal and a bad user experience. Seems like a straightforward enough fix to include with this PR.

[jzbahrai]

For placeholder, this is the template:

But the spreadsheet didnt preserve the placeholder name?

[jzbahrai]

Works for excel file!